Feature/vplay 11969 text lang bug fix #734
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the text track is changed without a re-tune then priv_aamps mPreferredTextTrack, and stream abstractions mTextTrackIndex are not updated to reflect the current track The manifest url can be set to null due to an issue with passing the same string into cache handler methods as multiple params by reference.
If the text track is changed without a re-tune then priv_aamps mPreferredTextTrack, and stream abstractions mTextTrackIndex are not updated to reflect the current track The manifest url can be set to null due to an issue with passing the same string into cache handler methods as multiple params by reference. The specified language via SetTextTrack() is ignored in perference to the prefferedTextLanguage list.
If the text track is changed without a re-tune then priv_aamps mPreferredTextTrack, and stream abstractions mTextTrackIndex are not updated to reflect the current track The manifest url can be set to null due to an issue with passing the same string into cache handler methods as multiple params by reference. The specified language set via SetTextTrack() is ignored in perference to the prefferedTextLanguage list.
DomSyna
force-pushed
the
feature/VPLAY-11969-text_lang_bug_fix
branch
from
4c64a85 to
6c40988
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses three related issues with text track handling in AAMP: stale text track information, incorrect text language preference priority, and manifest URL corruption in the cache handler.
Key Changes
- Cache Handler Fix: Modified
RetrieveFromPlaylistCacheandRetrieveFromInitFragmentCacheto pass URL by value instead of const reference, preventing corruption when the same string is used for bothurlandeffectiveUrlparameters - Text Track Selection Logic: Added check to respect pre-set preferred text tracks instead of always overriding with language preferences during stream initialization
- State Consistency: Added calls to
SetPreferredTextTrackandSetCurrentTextTrackIndexto maintain consistent state when text language changes don't trigger a retune
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| AampCacheHandler.h | Changed RetrieveFromPlaylistCache and RetrieveFromInitFragmentCache signatures to pass URL by value |
| AampCacheHandler.cpp | Implemented URL pass-by-value fix and simplified conditional logic for effective URL assignment |
| FakeAampCacheHandler.cpp | Updated fake implementation signatures to match new interface |
| StreamAbstractionAAMP.h | Added SetCurrentTextTrackIndex method to enable text track index updates without retune |
| fragmentcollector_hls.cpp | Modified text track selection to only auto-select from language preferences if no preferred track is already set |
| priv_aamp.cpp | Added calls to update preferred text track and current text track index when language changes without retune |
jfagunde
reviewed
Dec 5, 2025
If the text track is changed without a re-tune then priv_aamps mPreferredTextTrack, and stream abstractions mTextTrackIndex are not updated to reflect the current track The manifest url can be set to null due to an issue with passing the same string into cache handler methods as multiple params by reference. The specified language set via SetTextTrack() is ignored in perference to the prefferedTextLanguage list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VPLAY-11969: GetTextTrackInfo returns stale information
Fixes the following:
Stale information being returned for GetTextTrackInfo when no tune happens on track change
Using the preferred text language setting over the user setting when selecting the text track to use
Corruption of the manifest URL when it is passed into the cache by reference for both the URL and the effective URL
Risk: Low